-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lint/sort-imports): fix absolute path for sort-imports #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
Wondertan,
vgonkivs and
distractedm1nd
as code owners
August 31, 2023 11:31
walldiss
changed the title
chore(lint/sort-imports): fix absolute path
chore(lint/sort-imports): fix absolute path for sort-imports
Aug 31, 2023
distractedm1nd
previously approved these changes
Aug 31, 2023
Wondertan
reviewed
Aug 31, 2023
Codecov Report
@@ Coverage Diff @@
## main #2640 +/- ##
==========================================
- Coverage 51.13% 51.04% -0.10%
==========================================
Files 158 158
Lines 10662 10662
==========================================
- Hits 5452 5442 -10
- Misses 4735 4740 +5
- Partials 475 480 +5 |
vgonkivs
previously approved these changes
Sep 4, 2023
walldiss
dismissed stale reviews from vgonkivs and distractedm1nd
via
September 5, 2023 18:09
cf667c2
Wondertan
reviewed
Sep 5, 2023
Wondertan
approved these changes
Sep 6, 2023
distractedm1nd
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If repo folder name is different from "celestia-node"
lint
andsort-imprort
commands from Makefile will not work.