Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint/sort-imports): fix absolute path for sort-imports #2640

Merged
merged 5 commits into from
Sep 6, 2023

Conversation

walldiss
Copy link
Member

@walldiss walldiss commented Aug 31, 2023

If repo folder name is different from "celestia-node" lint and sort-imprort commands from Makefile will not work.

@walldiss walldiss added the kind:fix Attached to bug-fixing PRs label Aug 31, 2023
@walldiss walldiss self-assigned this Aug 31, 2023
@walldiss walldiss changed the title chore(lint/sort-imports): fix absolute path chore(lint/sort-imports): fix absolute path for sort-imports Aug 31, 2023
distractedm1nd
distractedm1nd previously approved these changes Aug 31, 2023
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Merging #2640 (d70db2d) into main (a5e01b9) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2640      +/-   ##
==========================================
- Coverage   51.13%   51.04%   -0.10%     
==========================================
  Files         158      158              
  Lines       10662    10662              
==========================================
- Hits         5452     5442      -10     
- Misses       4735     4740       +5     
- Partials      475      480       +5     

see 8 files with indirect coverage changes

vgonkivs
vgonkivs previously approved these changes Sep 4, 2023
Makefile Show resolved Hide resolved
@Wondertan Wondertan enabled auto-merge (squash) September 6, 2023 11:33
@Wondertan Wondertan merged commit 7601c08 into celestiaorg:main Sep 6, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants